Repository navigation
First version of stackstate version of base check - #1
Merged
Merged
Conversation
TizianoPerrucci
approved these changes
Jul 8, 2019
LouisParkin
added a commit
that referenced
this pull request
May 18, 2026
Follow-up to 61e9d4f — the pipeline (2534428169) surfaced two blockers the earlier sweep missed: 1. stackstate_checks_dev/setup.py:36 still hard-pinned pydantic==2.9.1, causing dep resolution conflicts with stackstate_checks_base[deps]==2.12.5 in every check that has a tox env (11 of 12 failing test_* jobs). setup.py files weren't in the earlier sweep grep — only requirements*.in/txt were. Now bumped to 2.12.5. 2. Pydantic 2.9 -> 2.12 changed the docs URL embedded in ValidationError messages from errors.pydantic.dev/2.9/v/... to .../2.12/v/... Tests in 7 files asserted against the literal expected message string, so all 16 assertions in test_agent_check.py/test_agent_check_v2.py broke (with same brittleness in 5 other test files that never ran due to #1). Updated all 7 to /2.12/. NOTE: these are still version-pinned and will break again on the next pydantic bump — version-agnostic assertion helper would be the durable fix, deferred to a separate refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first increment of the work.