make transaction inner tasks use RunContinuationsAsynchronously - #950
Merged
Conversation
…discussion, see issue #943); detect RunContinuationsAsynchronously in ResultBox completion, and set directly rather than deferred
NickCraver
approved these changes
Sep 12, 2018
NickCraver
left a comment
NickCraver
left a comment
Collaborator
There was a problem hiding this comment.
Looks good since we’re on 46+ across the board now - IMO removing the TaskSource helper layer that’s not adding any logic would help code readability and reasoning, but no strong feelings about it either.
| => new TaskCompletionSource<T>(asyncState, TaskCreationOptions.None); | ||
| /// <param name="options">The options to apply to the task</param> | ||
| public static TaskCompletionSource<T> Create<T>(object asyncState, TaskCreationOptions options = TaskCreationOptions.None) | ||
| => new TaskCompletionSource<T>(asyncState, options); |
Collaborator
There was a problem hiding this comment.
FWIW, we could delete this helper now that it’s a wrap with no logic over built-in.
Collaborator
Author
There was a problem hiding this comment.
@NickCraver I'd rather keep it all in one place even if it is just inlined by the JIT; I might add a JIT hint, but frankly I'd expect it to inline like a beast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion, see issue #943
RunContinuationsAsynchronouslyRunContinuationsAsynchronouslyinResultBoxcompletion, and set directly rather than deferred