Skip to content

docs: fix retry-category test in the custom RetryPolicy sample #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 1 commit into from
Oct 8, 2026
Merged

docs: fix retry-category test in the custom RetryPolicy sample #3265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/Failover.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,9 +1103,14 @@ public sealed class ReadOnlyOnlyRetryPolicy : RetryPolicy
{
public override RetryResult CanRetry(in FaultContext fault)
{
// only ever retry pure reads, and only on the same server
// only ever retry read-only (or safer) commands, and only on the same server;
// the retry category is a small numeric field inside CommandFlags, not a set of
// independent bits, so mask the whole field (CommandRetryNever spans it) and
// compare, rather than testing a single category value with "& != 0"
var category = fault.Flags & CommandFlags.CommandRetryNever;
if (fault.ErrorKind == RedisErrorKind.Loading
&& (fault.Flags & CommandFlags.CommandRetryReadOnly) != 0)
&& category != 0 // uncategorised commands are never retried
&& category <= CommandFlags.CommandRetryReadOnly)
{
return RetryResult.SameServer;
}
Expand Down
Loading