Skip to content

bugfix: string with length 1 throws exception #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikolayIT merged 1 commit into from
Jan 20, 2017
Merged

bugfix: string with length 1 throws exception #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/GenCode128/Code128Content.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ private int[] StringToCode128(string asciiData)
var csa1 = asciiBytes.Length > 0
? Code128Code.CodesetAllowedForChar(asciiBytes[0])
: Code128Code.CodeSetAllowed.CodeAorB;
var csa2 = asciiBytes.Length > 0
var csa2 = asciiBytes.Length > 1
? Code128Code.CodesetAllowedForChar(asciiBytes[1])
: Code128Code.CodeSetAllowed.CodeAorB;
var currentCodeSet = this.GetBestStartSet(csa1, csa2);
Expand Down
12 changes: 12 additions & 0 deletions Source/GenCode128Tests/ContentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,5 +372,17 @@ public void FullStringTest()
result = content.Codes;
Assert.AreEqual(10, result.Length, "Wrong number of code values in result");
}

[Test]
public void OneCharStringTest()
{
var content = new Code128Content("0");
var result = content.Codes;
Assert.AreEqual(4, result.Length, "Wrong number of code values in result");
Assert.AreEqual(104, result[0], "Start code wrong");
Assert.AreEqual(16, result[1], "Code value #1 wrong");
Assert.AreEqual(17, result[2], "Checksum wrong");
Assert.AreEqual(106, result[3], "Stop character wrong");
}
}
}