Fix: Enable function/class access from imported sol_N modules#2
Open
MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
Open
Fix: Enable function/class access from imported sol_N modules#2MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
Conversation
When importing a module via `import sol_0`, functions and classes defined in that module were not accessible (NameError), while variables worked correctly. Root cause: The source code import path used `obj_run(module, code)` which internally calls `pikaVM_run` without setting proper globals. This caused the DEF instruction handler to store functions on the wrong object (not the module). Fix: Use `pikaVM_run_ex` with explicit `cfg.globals = module` to ensure functions are defined on the module object, mirroring how the bytecode import path already handled this correctly. Test results: - test_vm_only.js: 158/158 passed - test_import_module.js: 12/13 passed (Test 8 "import sol_0 calls function" now works!) - test_vfs.js: 12/13 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing a module via
import sol_0, functions and classes defined in that module were not accessible (NameError), while variables worked correctly.Root cause: The source code import path used
obj_run(module, code)which internally callspikaVM_runwithout setting proper globals. This caused the DEF instruction handler to store functions on the wrong object (not the module).Fix: Use
pikaVM_run_exwith explicitcfg.globals = moduleto ensure functions are defined on the module object, mirroring how the bytecode import path already handled this correctly.Test results: