fix(vfs): skip size_t header in _sbf_FILEIO_write for bytes data#1
Open
MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
Open
fix(vfs): skip size_t header in _sbf_FILEIO_write for bytes data#1MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
MonteCrypto999 wants to merge 1 commit intoSolanaPython:solanafrom
Conversation
The arg_getBytes() function returns a pointer to the internal bytes storage which has layout: [size_t size][actual data bytes] When writing bytes via f.write(), the code was incorrectly writing from the start of the buffer (the size_t header) instead of the actual data. This fix adds + sizeof(size_t) to skip the header, consistent with how other code handles bytes data: - _solana_sbf.c:106 (CPI data) - _solana_sbf.c:181 (CPI data) - builtins_sbf.c:1342 (_sbf_builtins_str) - PikaVM.c:961 (bytes indexing, fixed in 64a521b) Without this fix, VFS writes would corrupt data by writing the size header bytes instead of the actual payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arg_getBytes() function returns a pointer to the internal bytes storage which has layout: [size_t size][actual data bytes]
When writing bytes via f.write(), the code was incorrectly writing from the start of the buffer (the size_t header) instead of the actual data.
This fix adds + sizeof(size_t) to skip the header, consistent with how other code handles bytes data:
Without this fix, VFS writes would corrupt data by writing the size header bytes instead of the actual payload.