Skip to content

key union selector, fix #22 - #27

Merged
SoftCreatR merged 1 commit into
SoftCreatR:mainfrom
SG5:union-keys
Oct 27, 2020
Merged

SoftCreatR merged 1 commit into
SoftCreatR:mainfrom
SG5:union-keys

Conversation

@SG5

@SG5 SG5 commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@SoftCreatR

Copy link
Copy Markdown
Owner

This also

resolves #15
resolves #23
resolves #24
resolves #25

@SoftCreatR
SoftCreatR merged commit 843d759 into SoftCreatR:main Oct 27, 2020
@SG5

SG5 commented Nov 10, 2020

Copy link
Copy Markdown
Contributor Author

@SoftCreatR could you add label hacktoberfest-accepted for this PR?

@SoftCreatR

Copy link
Copy Markdown
Owner

Sure, but is this required? From what I can remember, PRs count towards the goal, if they either have the label OR if they have been merged.

@SG5

SG5 commented Nov 10, 2020 •

Copy link
Copy Markdown
Contributor Author

Thanks
This year they changed rules to prevent PR spam. A repo or a PR should have label to be counted

@SoftCreatR

Copy link
Copy Markdown
Owner

Ah, yeah. I've removed the hacktoberfest Tag from the Repo. That might be the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants