Skip to content

large slice for short array, fix #7 - #26

Merged
SoftCreatR merged 1 commit into
SoftCreatR:mainfrom
SG5:negative-short-array
Oct 27, 2020
Merged

SoftCreatR merged 1 commit into
SoftCreatR:mainfrom
SG5:negative-short-array

Conversation

@SG5

@SG5 SG5 commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@SoftCreatR

SoftCreatR commented Oct 27, 2020 •

Copy link
Copy Markdown
Owner

Hi,

thank you for your PR, which looks good so far. I just want to let you know, that this also affects #9:

Before

--- Expected
+++ Actual
@@ @@
-'[]'
+'["one element","one element"]'

After

--- Expected
+++ Actual
@@ @@
-'[]'
+'["one element"]'

Maybe, you want to take a look, as soon as this PR has been merged.

@SG5

SG5 commented Nov 10, 2020

Copy link
Copy Markdown
Contributor Author

@SoftCreatR could you add label hacktoberfest-accepted for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants