This repository was archived by the owner on May 14, 2020. It is now read-only.
Repo 239 new FileType lookup() and missed file types - #59
Merged
Conversation
added 2 commits
July 11, 2019 17:06
…at FileApi accept FileType.lookup() stays backward compatible, but now it should also accept snake-cased type names
dimitrystd
approved these changes
Jul 11, 2019
andy-radchenko
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
FileType.lookup()logic to fit with the type strings thatFileApiacceptI looked here for the reference
FileType.lookup()stays backward compatible, but now it should also accept snake-cased type namesAlso added 4 file types which weren't present in the list - please check their mime types