Skip to content

[Aqara] Humidity_temp_sensor Battery capability change#1853

Merged
lelandblue merged 4 commits into
SmartThingsCommunity:mainfrom
hjl-aqara:aqara_humidity_temp_battery_cap
Feb 3, 2025
Merged

[Aqara] Humidity_temp_sensor Battery capability change#1853
lelandblue merged 4 commits into
SmartThingsCommunity:mainfrom
hjl-aqara:aqara_humidity_temp_battery_cap

Conversation

@hjl-aqara

@hjl-aqara hjl-aqara commented Jan 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@CLAassistant

CLAassistant commented Jan 7, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Kwang-Hui
Kwang-Hui reviewed Jan 7, 2025
View reviewed changes
Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua Outdated
end

local function device_init(driver, device)
battery_defaults.build_linear_voltage_init(2.6, 3.0)(driver, device)

@Kwang-Hui Kwang-Hui Jan 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

@Kwang-Hui

Kwang-Hui commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

STSE-3474

@Kwang-Hui

Kwang-Hui commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Hi @lelandblue , I couldn't find driver sharing link for this PR. could you check?

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Channel deleted.

greens
greens reviewed Jan 8, 2025
View reviewed changes
Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua
end

local function device_init(driver, device)
battery_defaults.build_linear_voltage_init(2.6, 3.0)(driver, device)

@greens greens Jan 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

battery_defaults is now unused

@Kwang-Hui Kwang-Hui Jan 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused and replaced with battery_level_handler

@greens greens Jan 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. But the require needs to be removed. That's why luacheck failed.

@Kwang-Hui Kwang-Hui Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. I get it. @hjl-aqara , Could you remove line number 1?

- local battery_defaults = require "st.zigbee.defaults.battery_defaults"

@hjl-aqara hjl-aqara Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just took care of it.

@github-actions

github-actions Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results

   64 files    404 suites   0s ⏱️
2 012 tests 2 012 ✅ 0 💤 0 ❌
3 474 runs  3 474 ✅ 0 💤 0 ❌

Results for commit 7775fb9.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua 94% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7775fb9

greens
greens reviewed Jan 8, 2025
View reviewed changes
Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/aqara/init.lua
@Kwang-Hui

Kwang-Hui commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

@lelandblue Could you help to merge this pull request?

@lelandblue
lelandblue merged commit 9fc44b4 into SmartThingsCommunity:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbaumler cbaumler Awaiting requested review from cbaumler
3 more reviewers
@Kwang-Hui Kwang-Hui Kwang-Hui left review comments
@greens greens greens approved these changes
@wkhenon wkhenon wkhenon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hjl-aqara @CLAassistant @Kwang-Hui @greens @wkhenon @lelandblue