Skip to content

Add initial set of drivers#1

Merged
greens merged 1 commit into
mainfrom
feature/initial_drivers
Aug 13, 2021
Merged

Add initial set of drivers#1
greens merged 1 commit into
mainfrom
feature/initial_drivers

Conversation

@greens

@greens greens commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@greens
greens requested review from tpmanley and varzac August 4, 2021 22:46

@greens greens left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should copyright/license text be added to profile and fingerprint files?

@varzac

varzac commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Should copyright/license text be added to profile and fingerprint files?

I don't think it's necessary I'll pull in @posborne and @azdle for their opinion as well as they both have experience with actual open source projects.

@azdle

azdle commented Aug 5, 2021

Copy link
Copy Markdown

First off, IANAL, but I really can't see those files being copyright worthy. IMHO they're not exactly a creative work.

We can add them, it won't hurt anything, but I don't feel like it's necessary. (Technically the the license header isn't necessary on any of the files, as long as there's a license file in the repo or it's made clear somewhere else. I think we just wanted to header as a reminder to people if they take the code and use it somewhere else.)

@varzac

varzac commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Speaking of I think we want to include https://www.apache.org/licenses/LICENSE-2.0.txt in the repo as well I think

@greens

greens commented Aug 5, 2021

Copy link
Copy Markdown
Contributor Author

@varzac it's already there: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/LICENSE

(Github lets you add a license file when you create a repo)

@azdle

azdle commented Aug 5, 2021

Copy link
Copy Markdown

Oh, also, my vent PR never made it in on the internal repo. Should I just YOLO it in? Or should I wait until to office opens back up so I can test it with real hardware and just open a PR on here?

@greens

greens commented Aug 5, 2021

Copy link
Copy Markdown
Contributor Author

@azdle Just pulled it in.

Comment thread drivers/SmartThings/zigbee-smoke-detector/fingerprints.yml Outdated
@greens
greens force-pushed the feature/initial_drivers branch from d62a04c to 0993ae1 Compare August 12, 2021 20:02
@greens
greens force-pushed the feature/initial_drivers branch from 0993ae1 to a667054 Compare August 12, 2021 20:18
@greens
greens merged commit cf6b05f into main Aug 13, 2021
@greens
greens deleted the feature/initial_drivers branch August 13, 2021 17:52
greens pushed a commit that referenced this pull request Jan 26, 2022
* Update fingerprints.yml

* Update init.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants