Add initial set of drivers#1
Conversation
greens
left a comment
There was a problem hiding this comment.
Should copyright/license text be added to profile and fingerprint files?
|
First off, IANAL, but I really can't see those files being copyright worthy. IMHO they're not exactly a creative work. We can add them, it won't hurt anything, but I don't feel like it's necessary. (Technically the the license header isn't necessary on any of the files, as long as there's a license file in the repo or it's made clear somewhere else. I think we just wanted to header as a reminder to people if they take the code and use it somewhere else.) |
|
Speaking of I think we want to include https://www.apache.org/licenses/LICENSE-2.0.txt in the repo as well I think |
|
@varzac it's already there: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/LICENSE (Github lets you add a license file when you create a repo) |
|
Oh, also, my vent PR never made it in on the internal repo. Should I just YOLO it in? Or should I wait until to office opens back up so I can test it with real hardware and just open a PR on here? |
|
@azdle Just pulled it in. |
d62a04c to
0993ae1
Compare
0993ae1 to
a667054
Compare
* Update fingerprints.yml * Update init.lua
No description provided.