feat: Trophy frog api - #437
Open
mariethepolarfox wants to merge 5 commits into
Open
Conversation
mariethepolarfox
marked this pull request as ready for review
July 11, 2026 13:40
j10a1n15
requested changes
Jul 11, 2026
| import tech.thatgravyboat.skyblockapi.utils.text.Text | ||
|
|
||
| enum class TrophyFishTier(val nameSuffix: Component, val displayName: String) { | ||
| enum class TrophyTier(val nameSuffix: Component, val displayName: String) { |
| @@ -1,10 +1,10 @@ | |||
| package tech.thatgravyboat.skyblockapi.api.area.isle.trophyfish | |||
| package tech.thatgravyboat.skyblockapi.api.datatype.defaults | |||
| import tech.thatgravyboat.skyblockapi.utils.text.Text | ||
|
|
||
| enum class TrophyFishRank(val displayName: Component) { | ||
| enum class TrophyRank(val displayName: Component) { |
| @@ -1,17 +1,17 @@ | |||
| package tech.thatgravyboat.skyblockapi.api.area.isle.trophyfish | |||
| package tech.thatgravyboat.skyblockapi.api.datatype.defaults | |||
| } | ||
|
|
||
| fun getId(tier: TrophyFishTier, default: TrophyFishTier = TrophyFishTier.BRONZE): SkyBlockId = SkyBlockId.item("${this.internalName}_${tier.takeUnless { it == TrophyFishTier.NONE } ?: default}") | ||
| fun getId(tier: TrophyTier, default: TrophyTier = TrophyTier.BRONZE): SkyBlockId = SkyBlockId.item("${this.internalName}_${tier.takeUnless { it == TrophyTier.NONE } ?: default}") |
| } | ||
|
|
||
| fun getCaught(type: TrophyFishType): Map<TrophyFishTier, Int> { | ||
| fun getCaught(type: TrophyFishType): Map<TrophyTier, Int> { |
| import tech.thatgravyboat.skyblockapi.api.events.base.SkyBlockEvent | ||
|
|
||
| data class TrophyFishCaughtEvent(val type: TrophyFishType, val tier: TrophyFishTier) : SkyBlockEvent() | ||
| data class TrophyFishCaughtEvent(val type: TrophyFishType, val tier: TrophyTier) : SkyBlockEvent() |
Collaborator
There was a problem hiding this comment.
this maybe too, idk you get the idea
Contributor
|
This pull request has conflicts, please resolve those before the pull request can be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.