Skip to content

Make everything final - #150

Closed
ruudk wants to merge 6 commits into
mainfrom
final
Closed

Make everything final#150
ruudk wants to merge 6 commits into
mainfrom
final

Conversation

@ruudk

@ruudk ruudk commented Nov 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

The idea is to make everything final as almost everything implements an interface already.

Why? https://matthiasnoback.nl/2018/09/final-classes-by-default-why/

I left the following not-final:

class AsynchronousCommandBus extends MessageBusSupportingMiddleware
class AsynchronousEventBus extends MessageBusSupportingMiddleware
class MessageBusSupportingMiddleware implements MessageBus
class CallableCollection
class CallableMap
class CommandBus extends MessageBusSupportingMiddleware
class EventBus extends MessageBusSupportingMiddleware

This will be released in a new major version together with other refactorings.

@ruudk
ruudk requested a review from cmodijk November 30, 2021 18:04
@ruudk ruudk closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmodijk cmodijk cmodijk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@ruudk @cmodijk