Add Support for LinkedIn provider#158
Closed
Dashue wants to merge 1 commit into
Closed
Conversation
Hook up to sample web project
Member
|
Hi @Dashue - thanks heaps for submitting a PR. Personally I hate LinkedIn but heaps of people still use em - and I guess for Authentication also 😄 Ok .. so this is coded against the current production code (even though that's the |
Author
|
Awesome! Will put it to good use as soon as you're done :) |
Author
|
Will make changes to target your ver 2.0 branch for this feature |
Member
|
👍 |
Author
|
Hey, saw I had this pull request open, where did we leave off LinkedIn auth? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Please review and let me know if anything needs fixing.
I tried with my own linkedin application, but redacted the keys when checking in, perhaps you have an app to be used for testing with?
It seems that linkedin is missing the following information: UserName, Locale, Gender. Not sure what to do about those.
Looking forward to getting your feedback!
Cheers