Skip to content

Allow repeated historical app log filters - #9113

Draft
grollest wants to merge 1 commit into
mainfrom
grollest/app-logs-combined-filters
Draft

grollest wants to merge 1 commit into
mainfrom
grollest/app-logs-combined-filters

Conversation

@grollest

@grollest grollest commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Historical log searches need to match more than one value of a filter without making separate requests.

WHAT is this pull request doing?

Allow the existing log filters in app logs-next to be repeated. Values within one filter match with OR; different filters still combine with AND. Multiple values use IN with a JSON-encoded string array; a single normalized value keeps EQUALS.

Validate at most 50 supplied values per filter and 1024 UTF-8 bytes per value. Keep query controls (--since, --until, --limit, --sort, --order) single-valued. Update command help and its manifest. The command remains hidden and experimental.

How to manually test your changes?

With an account and app that have App Logs API access and an API that supports IN:

pnpm shopify app logs-next --help
pnpm shopify app logs-next --client-id APP_CLIENT_ID --type webhook --topic orders/create --topic orders/updated --status failure --since 1h --limit 100 --json
pnpm shopify app logs-next --client-id APP_CLIENT_ID --type graphql --operation-name One --operation-name Two --since 1h --json
pnpm shopify app logs-next --since 1h --since 2h

Check that each search matches either requested value, with the webhook search still restricted to failures. The final command must reject the repeated query control before authentication.

Validation

  • 208 focused command, input, and service tests pass.
  • CLI build, app type-check, targeted ESLint, and git diff --check pass.
  • Built help shows repeatable log filters and single-valued query controls.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Nov 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant