Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Historical log searches need to match more than one value of a filter without making separate requests.
WHAT is this pull request doing?
Allow the existing log filters in
app logs-nextto be repeated. Values within one filter match with OR; different filters still combine with AND. Multiple values useINwith a JSON-encoded string array; a single normalized value keepsEQUALS.Validate at most 50 supplied values per filter and 1024 UTF-8 bytes per value. Keep query controls (
--since,--until,--limit,--sort,--order) single-valued. Update command help and its manifest. The command remains hidden and experimental.How to manually test your changes?
With an account and app that have App Logs API access and an API that supports
IN:Check that each search matches either requested value, with the webhook search still restricted to failures. The final command must reject the repeated query control before authentication.
Validation
git diff --checkpass.Checklist