Skip to content

Add Sidekick events to app logs-next - #9103

Open
grollest wants to merge 1 commit into
grollest/app-logs-restfrom
grollest/app-logs-sidekick
Open

grollest wants to merge 1 commit into
grollest/app-logs-restfrom
grollest/app-logs-sidekick

Conversation

@grollest

@grollest grollest commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Sidekick events are not yet available through historical CLI retrieval.

WHAT is this pull request doing?

Adds --type sidekick, reusing the target and result-status filters. Default queries include Sidekick events, and the human table shows the recorded target under Details.

Part 5 of the six-PR log-type stack, based on #9102. Tracking: EXTLOGS-108.

Validation

  • 260 focused tests passed, including shared filter wiring, native error fields, and Details/result rendering.
  • Targeted ESLint, app type-check, CLI bundle, manifest refresh, command snapshot, and diff checks passed.
  • Production tophat — 2026-11-09, tested head fbacc10556b0, against billing-event-tophat-oct27.
    • Shared seven-day UTC window: 2026-11-02T17:03:32Z to 2026-11-09T17:03:32Z.
    • --type sidekick --limit 20: 20 records returned (requested limit reached; this is a sample, not a total). JSON and human commands both exited 0; returned types and timestamps matched the request.
    • Human table: 20 rows, populated Details values, expected headings, and no GraphQL-only API column. Result/status counts matched the native JSON sample.
    • Live exact filters --target: 20 matching records, using values from the returned records; all returned values matched the predicates.
    • Record contents and filter values kept private. No source or service changes. This replaces the earlier production validation notes.
  • Prerequisite Rename the App Logs type from WEBHOOK_DELIVERY to WEBHOOK #9098 is merged; the WEBHOOK schema-freshness check now passes.
  • Command remains hidden; no changeset for this pre-release stack.

How to manually test your changes?

Using this branch's CLI with access to an app that has recent sidekick events:

shopify app logs-next --type sidekick --since 1h --limit 5
shopify app logs-next --type sidekick --target extensions/security_scan --status failure --since 1h --limit 5 --json

Confirm the recorded target appears under Details, filtering works, and JSON preserves the native event fields.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset with pnpm changeset add

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Nov 6, 2026
@grollest
grollest added this pull request to stack #9105 November 6, 2026 21:17
@isaacroldan
isaacroldan force-pushed the grollest/app-logs-sidekick branch from 6caebe7 to fbacc10 Compare November 9, 2026 12:44
@grollest
grollest marked this pull request as ready for review November 9, 2026 17:52
@grollest
grollest requested review from a team as code owners November 9, 2026 17:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant