Skip to content

Rename the App Logs type from WEBHOOK_DELIVERY to WEBHOOK - #9098

Merged
isaacroldan merged 1 commit into
mainfrom
grollest/app-logs-webhook-type
Nov 9, 2026
Merged

isaacroldan merged 1 commit into
mainfrom
grollest/app-logs-webhook-type

Conversation

@grollest

@grollest grollest commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The App Logs API change renames WEBHOOK_DELIVERY to WEBHOOK. The CLI needs to match so webhook and default mixed-type queries continue working after the backend change is deployed.

WHAT is this pull request doing?

Updates the API type mapping, generated enum, existing test expectations, and schema example to use WEBHOOK.

The CLI flag remains --type webhook.

Production validation

  • Production tophat — 2026-11-09, tested head 5ec8a3b142f2, against billing-event-tophat-oct27.
    • Shared seven-day UTC window: 2026-11-02T17:03:32Z to 2026-11-09T17:03:32Z.
    • --type webhook --limit 20: 20 records returned (requested limit reached; this is a sample, not a total). JSON and human commands both exited 0; returned types and timestamps matched the request.
    • Human table: 20 rows, populated Topic / operation values, expected headings, and no GraphQL-only API column. Result/status counts matched the native JSON sample.
    • Live exact filters --topic: 20 matching records, using values from the returned records; all returned values matched the predicates.
    • Record contents and filter values kept private. No source or service changes. This replaces the earlier production validation notes.

How to manually test your changes?

Using this branch’s CLI against a backend containing the rename, run from an app directory with recent webhook logs:

shopify app logs-next --type webhook --since 1h --limit 5 --json
shopify app logs-next --since 1h --limit 5 --json

Confirm both requests succeed and returned webhook records have type: "WEBHOOK".

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset with pnpm changeset add

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Nov 6, 2026
@isaacroldan
isaacroldan marked this pull request as ready for review November 9, 2026 11:29
@isaacroldan
isaacroldan requested review from a team as code owners November 9, 2026 11:29
@isaacroldan
isaacroldan added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit f9c1fc4 Nov 9, 2026
64 of 77 checks passed
@isaacroldan
isaacroldan deleted the grollest/app-logs-webhook-type branch November 9, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants