Repository navigation
Fix Cloudflare tunnel crash errors when stopping app dev on Windows - #9065
Merged
Merged
Conversation
1 of 4 tasks
isaacroldan
marked this pull request as ready for review
November 4, 2026 11:47
jplhomer
approved these changes
Nov 4, 2026
dmerand
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Stopping a working
app devsession on Windows can report that the Cloudflare tunnel crashed. The final process-tree cleanup kills the tunnel without marking its exit as an expected stop.WHAT is this pull request doing?
Stop the managed tunnel through the dev session's abort signal before process-tree cleanup. Also release it when preparation, process setup, or the session fails. Keep reporting unexpected tunnel failures.
No changeset is included in this PR; the
stable/5.0PR includes one.How to manually test your changes?
pnpm shopify app dev --path <app-directory>from this checkout with a linked app.q. Confirm that the session stops without the Cloudflare "process crashed after stablishing a connection" error.Validation
Checklist