Repository navigation
Partition GraphQL response caching by endpoint and token - #8888
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated requirements and includes focused regression coverage.
0 open findings
What changed in this PR
Partitions GraphQL caches by endpoint and token digest to prevent authenticated contexts from sharing responses.
Changes:
- Adds SHA-256 principal partitioning to cache keys.
- Tests endpoint/token isolation and token concealment.
- Adds a patch changeset.
| File | Description |
|---|---|
graphql.ts |
Adds principal digest to cache keys. |
graphql.test.ts |
Tests cache partitioning behavior. |
graphql-cache-principal-key.md |
Documents the user-facing fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
amcaplan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
GraphQL response cache entries are currently scoped by query and variables, but not by the authenticated request context. Identical requests made with a different endpoint or token should not reuse the same persisted response.
WHAT is this pull request doing?
Add a SHA-256 digest of the endpoint URL and token to each GraphQL response cache key. Raw tokens are never persisted, and the existing
cacheExtraKeyremains an additive partition.Existing cache entries will miss once after upgrading and then refill normally.
How to manually test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add