Repository navigation
Don't crash when the browser launcher is missing - #8886
Merged
Merged
Conversation
`open` resolves as soon as it calls `spawn`, before the OS reports whether the launcher exists. In a headless container without `xdg-open`, the failure arrives later as an `error` event on the child process. With no listener, Node throws it as an uncaught exception: `openURL` has already returned true, the CLI prints "Opened link", and then the global handler exits mid device-code poll with `spawn xdg-open ENOENT`. Wait for the child's `spawn` or `error` event and keep an `error` listener attached, so a failed launch returns false. Device-code login then prints the "Open this link" fallback and keeps polling. Co-authored-by: Isaac Roldan <[email protected]>
Contributor
Author
|
/snapit |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/notifications-system.d.ts@@ -26,7 +26,7 @@ declare const NotificationSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
@@ -43,7 +43,7 @@ declare const NotificationSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
@@ -86,7 +86,7 @@ declare const NotificationsSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
@@ -103,7 +103,7 @@ declare const NotificationsSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
@@ -122,7 +122,7 @@ declare const NotificationsSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
@@ -141,7 +141,7 @@ declare const NotificationsSchema: zod.ZodObject<{
id: string;
type: "info" | "error" | "warning";
message: string;
- frequency: "always" | "once" | "once_a_day" | "once_a_week";
+ frequency: "once" | "always" | "once_a_day" | "once_a_week";
ownerChannel: string;
title?: string | undefined;
cta?: {
|
Contributor
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running |
lizkenyon
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openresolves as soon as it callsspawn, before the OS reports whether the launcher exists. In a headless container withoutxdg-open, the failure arrives later as anerrorevent on the child process. With no listener, Node throws it as an uncaught exception:openURLhas already returned true, the CLI prints "Opened link", and then the global handler exits mid device-code poll withspawn xdg-open ENOENT.Wait for the child's
spawnorerrorevent and keep anerrorlistener attached, so a failed launch returns false. Device-code login then prints the "Open this link" fallback and keeps polling.WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to manually test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add