Repository navigation
Simplify dashboard extension import error handling - #8876
Open
isaacroldan wants to merge 1 commit into
Open
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
no-changelog
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The dashboard-extension import catch block combines completion, JSON construction, reporting, and exit handling. This follows Gonzalo's review comment on #8819.
WHAT is this pull request doing?
Separate failure classification from result construction so the catch has one JSON write and one flush. Preserve fatal errors, completed imports, telemetry, output, and exit codes.
Terminal Cancel keeps the existing silent exit code 1. Its JSON remains
{"status":"cancelled","reason":"directory-selection-cancelled","extensions":[],"errors":[],"identifiersUpdated":false}when no imports completed.How to manually test your changes?
shopify app import dashboard-extensions --path <copy> --json. Choose Cancel and check one cancelled result and exit code 1.changed: false. Run without--jsonto compare the original text.Checklist