Repository navigation
Fix bundling for multiple UI extension should-render targets - #8862
Merged
Merged
Conversation
one20
force-pushed
the
ca/cli-multi-should-render
branch
from
October 9, 2026 22:16
5046d58 to
a98e34f
Compare
one20
marked this pull request as ready for review
October 13, 2026 14:18
melissaluu
approved these changes
Oct 13, 2026
melissaluu
left a comment
Contributor
There was a problem hiding this comment.
🎩 and code looks good.
This PR should also be reviewed by the dev platform team as well since they own the CLI.
dmerand
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When a UI extension declares
should_renderfor multiple targets, the CLI replaces each condition entry with the next one. The generated conditions bundle registers only the last target, so earlier targets cannot use their declared conditions.WHAT is this pull request doing?
should_renderregistration into one conditions asset, with distinct generated import names for each target.@shopify/apppatch changeset.How to manually test your changes?
should_rendermodule.Checklist
patchbump and added a changeset.