Repository navigation
Make theme init default to stable Skeleton releases - #8786
Merged
Merged
Conversation
github-actions
Bot
added
the
no-changelog
Prompt for the stable release or upstream Skeleton theme when input is available. Use the published stable release with --latest or --no-input, and generate a name when prompting is disabled. Keep latest-tag clones non-shallow so Git can check out the tag.
karreiro
force-pushed
the
karreiro/theme-init-main
branch
from
October 6, 2026 09:23
5bc7955 to
c2d892a
Compare
karreiro
marked this pull request as ready for review
October 6, 2026 09:33
karreiro
requested review from
EvilGenius13
and
a balanced review from Copilot
October 6, 2026 09:33
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
--no-input unintentionally changes custom repositories to their latest tag, and generated-name behavior conflicts with command documentation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Defaults Skeleton theme initialization to stable releases while preserving an interactive upstream option.
Changes:
- Resolves and clones the latest stable Skeleton release.
- Adds interactive release selection and non-interactive name generation.
- Adds command and cloning tests.
| File | Description |
|---|---|
packages/theme/src/cli/services/init.ts |
Adds stable-release cloning and adjusts clone depth. |
packages/theme/src/cli/services/init.test.ts |
Tests stable-release resolution and cloning. |
packages/theme/src/cli/commands/theme/init.ts |
Selects stable or upstream behavior. |
packages/theme/src/cli/commands/theme/init.test.ts |
Tests interactive and non-interactive flows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
charlespwd
approved these changes
Oct 6, 2026
Use the stable release by default only for Skeleton theme. Preserve the default branch for custom repositories unless --latest is passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Skeleton theme's upstream branch can contain Liquid features that aren't available on every shop. A default
theme initcan therefore create a theme thattheme devcannot preview yet.WHAT is this pull request doing?
Offer the latest published stable Skeleton release or upstream in interactive mode, and use the stable release with
--no-inputand--latest. Generate a theme name when prompts are disabled and make latest-tag clones non-shallow.The patch changeset is included only in the stable/4.8 backport for the patch release.
How to manually test your changes?
shopify theme init stable-test --no-inputand compare the created theme with the latest published Skeleton release.shopify theme init upstream-test, choose Upstream, and confirm the prompt describes the possible shop compatibility gap.shopify theme init explicit-test --latestand confirm it clones the stable release.Checklist