Repository navigation
Conversation
Resolve inherited versions in the outbound events configuration so deploy comparison matches the server's materialized subscriptions. Co-Authored-By: Codex <[email protected]>
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
shopify app deployreports unchanged events configuration as updated when a subscription omitsapi_versionand inherits[events].api_version. The server stores the inherited version on each subscription, while the CLI compares it with a local config that still omits the field.WHAT is this pull request doing?
Resolve inherited subscription versions in the existing local-to-remote events transform, alongside relative URI resolution. Deploy comparison and upload then use the same effective versions as the server, without modifying the local TOML or requiring a server change.
Explicit overrides remain intact. Regression tests cover unchanged inherited and explicit versions, changing or removing an override, and changing the default version.
How to manually test your changes?
Use an app whose TOML sets
[events].api_versionand omitsapi_versionon an event subscription:The second deploy should show no events update. Setting a different subscription version, or removing an override that differs from the default, should still show an update.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset