Skip to content

Show subscription migration commands in CLI help - #8660

Merged
tyler-eon merged 4 commits into
mainfrom
tyler-eon/unhide-subscription-migrations
Sep 24, 2026
Merged

tyler-eon merged 4 commits into
mainfrom
tyler-eon/unhide-subscription-migrations

Conversation

@tyler-eon

@tyler-eon tyler-eon commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Subscription migration is going GA so we can make the commands generally visible in help and command discovery paths.

WHAT is this pull request doing?

  • Remove hidden from cancel, list, schedule, status, and unschedule.
  • Refresh the corresponding entries in the shipped oclif manifest.
  • Update command metadata tests and add regression coverage for text/JSON topic help and recursive root help.
  • Add a minor changeset. Command execution behavior is unchanged.
  • Update the readme and command snapshot.

How to manually test your changes?

  • Run shopify app --help and confirm the subscription-migrations topic appears.
  • Run shopify app subscription-migrations --help and confirm all five commands appear.
  • Repeat with --json, and check recursive root help with shopify help --all.

Validation

  • 272 tests passed across 25 migration/help/search test files.
  • TypeScript build passed.
  • Targeted ESLint and git diff --check passed. ESLint skipped the Nx module-boundary rule because no cached project graph was available.
  • A broader launcher-test run timed out; launcher-level checks remain unverified.

Checklist

  • Considered cross-platform impacts; help regression tests use fileURLToPath.
  • Considered documentation changes; existing command descriptions are now discoverable.
  • Considered analytics changes; none needed for visibility-only changes.
  • Added a minor changeset for this user-facing visibility fix.

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Sep 24, 2026
@tyler-eon
tyler-eon marked this pull request as ready for review September 24, 2026 20:05
@tyler-eon
tyler-eon requested review from a team as code owners September 24, 2026 20:05

@Suleimanlatrsh Suleimanlatrsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted locally, all 5 commands show up in app --help and app subscription-migrations --help 👍

One thing: the topic has no description, so oclif borrows cancel's summary:
app subscription-migrations Cancels app subscription migration operations.
Could you add an app:subscription-migrations entry to oclif.topics in packages/cli/package.json? Something like "Migrate app subscriptions to Shopify-managed pricing." Then regen the README and docs.

Nit: changeset should probably be minor since it's a new user-facing feature.

@tyler-eon

Copy link
Copy Markdown
Contributor Author

@Suleimanlatrsh Updated with the two changes.

@tyler-eon
tyler-eon added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit bf62b76 Sep 24, 2026
31 checks passed
@tyler-eon
tyler-eon deleted the tyler-eon/unhide-subscription-migrations branch September 24, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants