Skip to content

Add code from flask-webgoat - #2

Merged
ursachec merged 9 commits into
masterfrom
claudiu/webgoat
May 4, 2021
Merged

ursachec merged 9 commits into
masterfrom
claudiu/webgoat

Conversation

@ursachec

@ursachec ursachec commented Apr 30, 2021 •

Copy link
Copy Markdown
Contributor

@ursachec
ursachec requested review from hubertp and prabhu April 30, 2021 09:28
Comment thread .github/workflows/ngsast.yml Outdated
Comment thread .github/workflows/ngsast.yml Outdated
Comment thread .github/workflows/ngsast.yml Outdated
Comment thread .github/workflows/ngsast-docker.yml Outdated
Comment thread .github/workflows/ngsast.yml Outdated
So as to not trigger two analyses per PR
Non-example workflow will be part of a separate branch
@ursachec
ursachec requested a review from prabhu April 30, 2021 12:51

@hubertp hubertp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove example GH action integration. those should only be present in shiftleft-python-example (and don't have to be .example but real integrations)

@ursachec

Copy link
Copy Markdown
Contributor Author

@hubertp removed

@ursachec
ursachec requested a review from hubertp April 30, 2021 13:03

@hubertp hubertp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove shiftleft.yml
What's the reason for Dockerfile? I don't think any of our demos packages stuff into a container.

I think once that is done, this is gtg but cannot be merged until appropriate infra setup is complete as well.
You can always create an identical shiftleft-python-example though

@ursachec
ursachec requested a review from hubertp April 30, 2021 13:15
@ursachec

ursachec commented Apr 30, 2021 •

Copy link
Copy Markdown
Contributor Author

done @hubertp.

@ursachec

ursachec commented Apr 30, 2021 •

Copy link
Copy Markdown
Contributor Author

Will only be merged on Tuesday, May 4th 2021

@ursachec
ursachec force-pushed the claudiu/webgoat branch from e76f47c to b71acc2 Compare May 3, 2021 12:05
@ursachec
ursachec requested a review from alexhornbake May 4, 2021 15:33
@ursachec
ursachec merged commit fb84407 into master May 4, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the claudiu/webgoat branch May 4, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants