Skip to content

Commit a8434f7

Browse files
AkhtarAmirAkhtarAmir
authored
Apply suggestions from code review
1 parent c3c3576 commit a8434f7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎plugins/aws/msk/mskClusterPublicAccess.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ module.exports = {
4545
cluster.BrokerNodeGroupInfo.ConnectivityInfo.PublicAccess.Type &&
4646
cluster.BrokerNodeGroupInfo.ConnectivityInfo.PublicAccess.Type.toUpperCase() === 'DISABLED') {
4747
helpers.addResult(results, 0,
48-
'MSK cluster does not have public access enabled', region, resource);
48+
'MSK cluster is not publicly accessible', region, resource);
4949
} else {
5050
helpers.addResult(results, 2,
51-
'MSK cluster has public access enabled', region, resource);
51+
'MSK cluster is publicly accessible', region, resource);
5252
}
5353
}
5454

‎plugins/aws/msk/mskClusterPublicAccess.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ describe('mskClusterPublicAccess', function () {
9999
mskClusterPublicAccess.run(cache, {}, (err, results) => {
100100
expect(results.length).to.equal(1);
101101
expect(results[0].status).to.equal(2);
102-
expect(results[0].message).to.include('MSK cluster has public access enabled');
102+
expect(results[0].message).to.include('MSK cluster is not publicly accessible');
103103
done();
104104
});
105105
});
@@ -109,7 +109,7 @@ describe('mskClusterPublicAccess', function () {
109109
mskClusterPublicAccess.run(cache, {}, (err, results) => {
110110
expect(results.length).to.equal(1);
111111
expect(results[0].status).to.equal(0);
112-
expect(results[0].message).to.include('MSK cluster does not have public access enabled');
112+
expect(results[0].message).to.include('MSK cluster is not publicly accessible');
113113
done();
114114
});
115115
});

0 commit comments

Comments
 (0)