Skip to content

Emit GC.KeepAlive in cleanup code to keep interface class instances alive.#97

Merged
jkoritzinsky merged 1 commit into
masterfrom
gckeepalive
Jan 1, 2019
Merged

Emit GC.KeepAlive in cleanup code to keep interface class instances alive.#97
jkoritzinsky merged 1 commit into
masterfrom
gckeepalive

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Fixes #95.

@codecov

codecov Bot commented Jan 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #97 into master will increase coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #97      +/-   ##
=========================================
+ Coverage   58.49%   58.5%   +0.01%     
=========================================
  Files         150     150              
  Lines        9156    9168      +12     
  Branches     1124    1124              
=========================================
+ Hits         5356    5364       +8     
- Misses       3410    3412       +2     
- Partials      390     392       +2
Impacted Files Coverage Δ
...enerator/Marshallers/ArrayOfInterfaceMarshaller.cs 6.52% <0%> (ø) ⬆️
...rpGen/Generator/Marshallers/InterfaceMarshaller.cs 23.86% <100%> (ø) ⬆️
SharpGen/Generator/Marshallers/MarshallerBase.cs 52.21% <100%> (+2.04%) ⬆️
SharpGen/Model/CsMarshalBase.cs 70.83% <0%> (-4.17%) ⬇️
SharpGen/Model/CppElement.Extensions.cs 44.23% <0%> (-1.93%) ⬇️
SharpGen/Parser/CppParser.cs 75.3% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27480d4...396e2c8. Read the comment docs.

@jkoritzinsky jkoritzinsky merged commit 017c188 into master Jan 1, 2019
@delete-merged-branch delete-merged-branch Bot deleted the gckeepalive branch January 1, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant