Skip to content

Account for null struct-to-class instances when marshalling from native.#81

Merged
jkoritzinsky merged 1 commit into
masterfrom
struct-to-class-marshalling-fix
Sep 5, 2018
Merged

Account for null struct-to-class instances when marshalling from native.#81
jkoritzinsky merged 1 commit into
masterfrom
struct-to-class-marshalling-fix

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Fixes #80

@codecov

codecov Bot commented Sep 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #81 into master will decrease coverage by 0.09%.
The diff coverage is 30.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #81     +/-   ##
=========================================
- Coverage   58.55%   58.46%   -0.1%     
=========================================
  Files         150      150             
  Lines        9135     9148     +13     
  Branches     1121     1123      +2     
=========================================
- Hits         5349     5348      -1     
- Misses       3396     3406     +10     
- Partials      390      394      +4
Impacted Files Coverage Δ
...Marshallers/StructWithNativeTypeArrayMarshaller.cs 6.57% <0%> (ø) ⬆️
...ator/Marshallers/StructWithNativeTypeMarshaller.cs 72.47% <100%> (ø) ⬆️
SharpGen/Generator/Marshallers/MarshallerBase.cs 50.17% <23.52%> (-1.69%) ⬇️
SharpGen/Model/CppElement.Extensions.cs 44.23% <0%> (-1.93%) ⬇️
SharpGen/Parser/CppParser.cs 75.15% <0%> (-0.16%) ⬇️
SharpGen/Model/CsMarshalBase.cs 70.83% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31c1cb...46ebb0a. Read the comment docs.

@jkoritzinsky jkoritzinsky merged commit 7633ae2 into master Sep 5, 2018
@delete-merged-branch delete-merged-branch Bot deleted the struct-to-class-marshalling-fix branch September 5, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant