Repository navigation
Conversation
kirillNay
suggested changes
Jun 4, 2023
| return price; | ||
| } | ||
|
|
||
| public String declension(double sum) { |
There was a problem hiding this comment.
⏫ Так как методы declension и price используются только в классе Calculator, их можно сделать private.
| public String declension(double sum) { | ||
| sum = Math.floor(sum); | ||
| for(int i=11; i<=14; i++) { | ||
| if((sum-i)%100 == 0) { |
There was a problem hiding this comment.
Очень интересный алгоритм определения правильного окончания.
⚠ ️Немного сбивает с толку то, что все проверки находятся
внутри цикла. К сожалению, такой алгоритм не покрывает сценарий, когда sum равна 12, 13 или 14. В этих случаях мы всегда
будем получать "рубля".
Советую оставить в цилке только первую проверку
for(int i=11;i<=14;i++){
if((sum-i)%100==0){
return" рублей.";
}
}А следом проверять остальные условия.
kirillNay
suggested changes
Jun 4, 2023
| } | ||
| } No newline at end of file | ||
| } | ||
| class Calculator{ |
There was a problem hiding this comment.
⏫ Желательно все классы держать в разных файлах, чтобы было проще ориентироваться внутри одного файла
kirillNay
approved these changes
Jun 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.