UserAuth should be retrieved using integer ID in RavenUserAuthRepository. - #30
Closed
jongeorge1 wants to merge 1 commit into
Closed
UserAuth should be retrieved using integer ID in RavenUserAuthRepository.#30jongeorge1 wants to merge 1 commit into
jongeorge1 wants to merge 1 commit into
Conversation
…, as this can cause Raven to load the wrong document.
Author
|
Sorry, just noticed that this pull request is almost identical to #22. What needs to happen in order to get one of them progressed? |
Contributor
|
Just needed to be bumped as I seemed to lose notification on it :), #22 is merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetUserAuth method needs to convert the userAuthId to an int before loading the UserAuth from Raven. If a string is used, Raven can load the wrong document causing a cast exception when it tries to convert it to a UserAuth.