Compatibility with Python 3 and improved sandbox operation - #121
Draft
amotl wants to merge 26 commits into
Draft
Conversation
user/password is guest/guest.
This probably will have to be made configurable later.
user/password is guest/guest.
This probably will have to be made configurable later.
Don't use any of 60, 30, or 10 seconds, but use 4.2 seconds instead. This will yield faster reactions for recovery from any intermittent problems.
user/password is guest/guest.
This probably will have to be made configurable later.
This will probably have to be turned on again later, but for development it is easier without.
- Use `items()` instead of `iteritems()` - Compare character types against `str` and `bytes` instead of `unicode` - Configure CherryPy to use UTF-8 encoding
…Video This patch apparently fixes some threading issues which have been observed after switching to Python 3.
This reverts commit 2e9f534.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
following up on #120, we are relatively confident this patch improves the situation on Python 3 significantly.
The patch also has some commits unrelated to Python 3 compatibility, which improve the operation in sandbox/development mode, like the temporary removal of SSL support for AMQP, and some adjustments to the logging settings. The corresponding commits will probably have to be removed and/or adjusted again.
Kudos to @Tonkenfo for making this happen.
With kind regards,
Andreas.