Type agnostic, finite recursive_bottom_eltype function - #55
Merged
ChrisRackauckas merged 1 commit intoJun 28, 2019
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Before the `recursive_bottom_eltype` function was written with only numeric types in mind. For those, it worked. But for non-numeric types it recused infinitely, causing a `StackOverflowError`. Now it works on any type and is sure to recurse only a finite number of time, thus always end and return a result. I also added tests that cover this specific function, testing numbers with and without units as well as chars and strings.
Member
|
Wow, somehow I completely didn't see this PR. Sorry! |
Contributor
Author
No worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the
recursive_bottom_eltypefunction was written with onlynumeric types in mind. For those, it worked. But for non-numeric types
it recused infinitely, causing a
StackOverflowError.Now it works on any type and is sure to recurse only a finite number of
time, thus always end and return a result.
The recursion ends, when the given argument
ais the same aseltype(a). So, as there is a limited amount of types in Julia, we will only recurse a limited amount of times.I also added tests that cover this specific function, testing numbers
with and without units as well as chars and strings.