Specialize Base.similar for VectorOfArray with multidimensional parent - #359
Merged
ChrisRackauckas merged 10 commits intoFeb 22, 2024
Merged
Conversation
Contributor
Author
|
@ranocha I think with these changes, we can deal with multidimensional arrays of For example, the following works for me under this PR: using StaticArrays
using RecursiveArrayTools
using OrdinaryDiffEq
function rhs!(duu::VectorOfArray, uu::VectorOfArray, p, t)
du = parent(duu)
u = parent(uu)
du .= u
end
u = fill(SVector{2}(ones(2)), 2, 3)
ode = ODEProblem(rhs!, VectorOfArray(u), (0.0, 1.0))
sol = solve(ode, Tsit5()) |
Member
|
Add that as a regression test in the downstream portion (https://github.com/SciML/RecursiveArrayTools.jl/blob/master/test/upstream.jl which is for some reason named upstream we should fix that and move it to the other test group https://github.com/SciML/RecursiveArrayTools.jl/blob/master/test/runtests.jl#L63 |
Co-authored-by: Christopher Rackauckas <[email protected]>
ChrisRackauckas
approved these changes
Feb 21, 2024
jlchan
commented
Feb 21, 2024
Member
Nice 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specializes
Base.similarforVectorOfArraywith a homogeneous (e.g., all elements are the same type) multidimensional parent array (introduced in #357). This ensures thatsimilar(VectorOfArray(array)).uis similar toarray.uwherearrayis a homogeneous multi-dimensional array.This PR also adds
Base.parentforVectorOfArray(parent(vec)just returnsvec.u)