Update vector_of_array.jl - #355
Merged
Merged
Conversation
Contributor
Author
|
Oops this might violate the copying semantics of getindex |
AayushSabharwal
requested changes
Feb 20, 2024
AayushSabharwal
left a comment
AayushSabharwal
left a comment
Member
There was a problem hiding this comment.
Copying isn't really an issue here, since we can't avoid it. However, I'd recommend using the Adapt.adapt(...) wrapper instead of Array. That way the output type matches the type of the contained arrays.
Contributor
Author
|
I meant to say that |
Member
|
I think it copies, and anyway |
Contributor
Author
|
The following method of I'll probably keep the original method and add one with numeric elements that forwards the indices to the inner array. |
Contributor
Author
|
I updated my pr to just add a new method which will fix the broken case. I also rebased onto the main branch. I hope this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #354
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.