feat: add ability to set VectorOfArray with Array using broadcast - #309
Merged
ChrisRackauckas merged 6 commits intoDec 22, 2023
Merged
Conversation
AayushSabharwal
force-pushed
the
as/broadcast-from-array
branch
from
December 21, 2023 07:41
a30d7d0 to
4d8130e
Compare
|
|
||
| @inline function Base.copyto!(dest::AbstractVectorOfArray, | ||
| bc::Broadcast.Broadcasted{<:Broadcast.DefaultArrayStyle}) | ||
| bc = Broadcast.flatten(bc) |
Member
There was a problem hiding this comment.
won't this allocate?
Member
There was a problem hiding this comment.
guess not, I'm adding a test for that.
Member
Author
There was a problem hiding this comment.
Which part? unpack_voa creates views, so it won't if the target array is mutable. If the target isn't, then it has to allocate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.