Skip to content

fix: fix broadcasted assignment to VOA of StaticArrays - #304

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
AayushSabharwal:as/broadcast-fix
Dec 20, 2023
Merged

ChrisRackauckas merged 1 commit into
SciML:masterfrom
AayushSabharwal:as/broadcast-fix

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal

Copy link
Copy Markdown
Member Author

Why does CI randomly get cancelled like that?

@ChrisRackauckas

Copy link
Copy Markdown
Member

fail fast

@AayushSabharwal

Copy link
Copy Markdown
Member Author

Ah, so 1.6 is making it fail? I'll remove 1.6 CI so this actually runs

@ChrisRackauckas

Copy link
Copy Markdown
Member

yes exactly. Just rebase onto master, it's being prepared to release all together

@AayushSabharwal

Copy link
Copy Markdown
Member Author

This might need another rebase once #298 is merged

@ChrisRackauckas

Copy link
Copy Markdown
Member

Rebase and 🙏

@ChrisRackauckas

Copy link
Copy Markdown
Member

Looks like you have an infinite loop somewhere?

@ChrisRackauckas
ChrisRackauckas merged commit b7da0a2 into SciML:master Dec 20, 2023
@AayushSabharwal
AayushSabharwal deleted the as/broadcast-fix branch December 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants