fix: fix bugs - #298
Merged
Merged
fix: fix bugs#298
Conversation
AayushSabharwal
force-pushed
the
as/rerun-ci
branch
from
December 17, 2023 07:19
d862c63 to
c647499
Compare
Member
Author
|
Tests are fixed by SciMLBase and DiffEqBase PRs |
Member
Author
|
In hindsight, I guess CI targeting 1.9 specifically should be removed until 1.10 is out. Seems pointless using CI hours on identical tests. |
| @@ -1,3 +1,5 @@ | |||
| using SparseArrays | |||
Member
There was a problem hiding this comment.
wrong location for this.
Member
Author
There was a problem hiding this comment.
I'll fix this and drop 1.9-specific CI once tests pass. It's absurd that they're taking over half an hour
Member
Author
|
There is something wrong with CI |
Member
|
Rebase |
AayushSabharwal
force-pushed
the
as/rerun-ci
branch
2 times, most recently
from
December 19, 2023 11:19
770c1f8 to
54e7b48
Compare
5 tasks done
Member
Author
|
I'm working on fixing compat |
AayushSabharwal
force-pushed
the
as/rerun-ci
branch
from
December 19, 2023 12:48
54e7b48 to
f8cfd1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.