adding NamedArrayPartition type - #293
Merged
Merged
Conversation
6 tasks
ChrisRackauckas
approved these changes
Dec 10, 2023
jlchan
commented
Dec 10, 2023
Contributor
Author
|
Sorry, dismissed the review after fixing a conflict |
Member
|
bump the version down to test it. |
Contributor
Author
Thanks for the tip. Done in e6d2680, mind approving CI once more? |
Contributor
Author
|
Formatting tests were failing for a bunch of files; is it OK if I just lump a bunch of formatting commits into this PR or would you prefer that in a separate one? |
Member
|
Don't run the formatter, it needs an update. |
Contributor
Author
|
Thanks for catching that I forgot to load the packages in my tests @ChrisRackauckas. I think I've fixed the last failing test - would you mind approving the CI again? |
Member
|
Last thing, just add to the docs. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
NamedArrayPartitiontype in https://github.com/jlchan/StartUpDG.jl; in case it's useful, here are the changes as a PR.The array type is just an array partition with named fields, e.g.,
The main difference from
ArrayPartitionis that I require each individual array to have the sameeltype. I forgot why I did this originally, but I'm happy to fix this if needed.