fix copyat_or_push! for StaticArrays - #21
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 62.55% 64.15% +1.59%
==========================================
Files 3 3
Lines 211 212 +1
==========================================
+ Hits 132 136 +4
+ Misses 79 76 -3
Continue to review full report at Codecov.
|
Member
|
Can this be specialized to SArray? This is touching on the mutability issue but I think it's important for mutable field vectors to be fast here. |
Member
Author
|
I've implemented some additional checks as discussed in #19. |
ChrisRackauckas
approved these changes
Oct 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some problems for OrdinaryDiffEq with callbacks if
u <: StaticArray.