Skip to content

fix copyat_or_push! for StaticArrays - #21

Merged
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ranocha:pull-request/9065539d
Oct 12, 2017
Merged

ChrisRackauckas merged 2 commits into
SciML:masterfrom
ranocha:pull-request/9065539d

Conversation

@ranocha

@ranocha ranocha commented Oct 11, 2017

Copy link
Copy Markdown
Member

This fixes some problems for OrdinaryDiffEq with callbacks if u <: StaticArray.

@coveralls

coveralls commented Oct 11, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 63.507% when pulling 9065539 on ranocha:pull-request/9065539d into a70c164 on JuliaDiffEq:master.

@codecov

codecov Bot commented Oct 11, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #21 into master will increase coverage by 1.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   62.55%   64.15%   +1.59%     
==========================================
  Files           3        3              
  Lines         211      212       +1     
==========================================
+ Hits          132      136       +4     
+ Misses         79       76       -3
Impacted Files Coverage Δ
src/utils.jl 51.42% <100%> (+5.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70c164...4999bca. Read the comment docs.

@ChrisRackauckas

Copy link
Copy Markdown
Member

Can this be specialized to SArray? This is touching on the mutability issue but I think it's important for mutable field vectors to be fast here.

@ranocha

ranocha commented Oct 12, 2017

Copy link
Copy Markdown
Member Author

I've implemented some additional checks as discussed in #19.

@coveralls

coveralls commented Oct 12, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.6%) to 64.151% when pulling 4999bca on ranocha:pull-request/9065539d into a70c164 on JuliaDiffEq:master.

@ChrisRackauckas
ChrisRackauckas merged commit 97b3bb7 into SciML:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants