Only require ArrayInterfaceCore - #204
Merged
Merged
Conversation
Before and after:
```julia
julia> @time_imports using RecursiveArrayTools
10.7 ms ┌ MacroTools
19.2 ms ┌ ZygoteRules
2.8 ms ┌ Compat
1.4 ms ┌ Requires
123.4 ms ┌ FillArrays
507.7 ms ┌ StaticArrays
17.8 ms ┌ Preferences
19.6 ms ┌ JLLWrappers
184.0 ms ┌ LLVMExtra_jll
5.1 ms ┌ CEnum
108.6 ms ┌ LLVM
1.9 ms ┌ Adapt
804.4 ms ┌ GPUArrays
5.8 ms ┌ DocStringExtensions
1.3 ms ┌ IfElse
39.8 ms ┌ RecipesBase
40.6 ms ┌ Static
504.1 ms ┌ ArrayInterface
73.6 ms ┌ ChainRulesCore
2332.6 ms RecursiveArrayTools
julia> @time_imports using RecursiveArrayTools
10.1 ms ┌ MacroTools
18.7 ms ┌ ZygoteRules
2.6 ms ┌ Compat
123.9 ms ┌ FillArrays
521.7 ms ┌ StaticArrays
18.4 ms ┌ Preferences
20.2 ms ┌ JLLWrappers
173.5 ms ┌ LLVMExtra_jll
4.8 ms ┌ CEnum
103.7 ms ┌ LLVM
2.0 ms ┌ Adapt
815.3 ms ┌ GPUArrays
5.2 ms ┌ DocStringExtensions
40.3 ms ┌ RecipesBase
2.6 ms ┌ ArrayInterfaceCore
56.6 ms ┌ ChainRulesCore
1822.5 ms RecursiveArrayTools
```
Member
Author
|
@oschultz yes, it's all StaticArrays and GPUArrays. Ugh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before and after: