Fix boolean mask indexing - #183
Merged
Merged
Conversation
Contributor
Author
|
@ChrisRackauckas Could you please take a look? Also, does the GPU CI need to be manually triggered or is it part Github Actions CIs? |
Member
|
oh, BuildKite must not trigger on outside PRs... |
Member
|
I'm going rogue. I'll merge and see. |
Contributor
Author
|
@ChrisRackauckas Seems to have worked! A minor issue that I forgot to delete line 80 (which does nothing!) 😢 But, I guess should be fine (?). RecursiveArrayTools.jl/src/vector_of_array.jl Lines 76 to 82 in 83fee26 |
Member
|
I just did a small commit removing it. No worries. |
YingboMa
reviewed
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.