Speed up some use cases of ArrayPartition - #163
Merged
ChrisRackauckas merged 2 commits intoJul 25, 2021
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
Contributor
Author
|
I've improved that julia> @benchmark f!($c, $a, $b)
BenchmarkTools.Trial: 10000 samples with 999 evaluations.
Range (min … max): 7.885 ns … 34.613 ns ┊ GC (min … max): 0.00% … 0.00%
Time (median): 7.972 ns ┊ GC (median): 0.00%
Time (mean ± σ): 7.990 ns ± 0.406 ns ┊ GC (mean ± σ): 0.00% ± 0.00%
▂▂█▁▄▄
▂▂▂▂▁▁▂▁▂▂▁▂▂▂▂▂▂▃▃▃▃▃▃▄▄▅▄▅▄▄▇▆██████▇▇▄▅▅▄▇▆▇▄▄▃▃▂▂▃▂▃▃▃ ▃
7.88 ns Histogram: frequency by time 830 ns <
Memory estimate: 0 bytes, allocs estimate: 0. |
ChrisRackauckas
approved these changes
Jul 24, 2021
ChrisRackauckas
left a comment
ChrisRackauckas
left a comment
Member
There was a problem hiding this comment.
oh yes, just mapping over the tuple is a lot better, great idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first batch of changes related to #160 . Most changes are related to the fact that
mapis much more friendly to Julia compiler than broadcasting so I've replaced a bunch of unnecessary broadcasts withmap. The other thing is that the loop in assignment broadcast is very problematic -- ideally compiler should be able to constant-propagateNand unroll the loop but it seems that doing so breaks some other optimizations. This change helps a bit but it's still not enough.