Define the custom adjoint on a more general ArrayPartition constructor - #119
Merged
ChrisRackauckas merged 1 commit intoDec 21, 2020
Merged
Conversation
ChrisRackauckas
approved these changes
Nov 2, 2020
Member
|
Thanks! |
Member
|
https://travis-ci.org/github/SciML/RecursiveArrayTools.jl/builds/740939125#L439 looks like it needs to hit the 3 argument version. |
Contributor
Author
|
No, this error is the reason why the other PR needs to be merged first. At the moment, the generated |
martenlienen
force-pushed
the
array-partition-adjoint
branch
from
December 21, 2020 09:08
04d6eb6 to
8c60597
Compare
Contributor
Author
|
Now that v0.2.1 of ZygoteRules has been released, this PR is ready to be merged as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing the adjoint of a
SecondOrderODEProblemrequires an adjoint for this constructor because of the following line.https://github.com/SciML/DiffEqBase.jl/blob/9f0875ad24ac9c2f5784b242eba5344807f278e7/src/problems/ode_problems.jl#L153
This PR depends on FluxML/ZygoteRules.jl#12 because of the anonymous value type argument. That was a fun one to debug :)