Skip to content

Define Base._parentsmatch for AbstractVectorOfArray #495

Description

@bertini97

Copying from a view to a view requires Base._parentsmatch(::TypeOfView1, ::TypeOfView2) I think for optimization reasons. RecursiveArrayTools currently doesn't define this.

Two solutions:

  • RecursiveArrayTools defines
    Base._parentsmatch(::AbstractArray, ::AbstractVectorOfArray) = false
  • Base defines
    Base._parentsmatch(::Any, ::Any) = false

It's weird that base doesn't define a default for this. They didn't think someone would extend views?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions