Use AllocCheck static analysis for allocation tests - #59
Merged
ChrisRackauckas merged 1 commit intoJan 26, 2026
Merged
Conversation
Replace runtime @allocated tests with AllocCheck's check_allocs() for more robust allocation checking: - check_allocs() does compile-time LLVM IR analysis to find allocation sites, rather than measuring runtime allocations which can be noisy due to GC bookkeeping artifacts on Julia 1.12+ - No warmup needed since it's static analysis, not runtime measurement - Tests verify type combinations don't allocate, not specific data values - Added coverage for both Int64 and Float64 vector types This resolves the flaky @allocated tests that were spuriously reporting non-zero allocations on Julia 1.12 for large vectors. Co-Authored-By: Chris Rackauckas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces flaky runtime
@allocatedtests with AllocCheck'scheck_allocs()for robust static allocation analysis.Changes
check_allocs(func, types)which analyzes LLVM IR for allocation sites at compile-time, rather than@allocatedwhich measures runtime allocationsInt64andFloat64vector types@allocatedtests spuriously reported non-zero allocations (16 bytes forfindfirstequal, 576 bytes forfindfirstsortedequal) on large vectors due to GC measurement noiseWhy static analysis is better
@allocated(runtime)check_allocs()(static)Depends on
Test plan
🤖 Generated with Claude Code