READY FOR REVIEW

Summary

• Fixed the years on the input for in house

Review By (Date)

• when time

Criticality

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to interactives/mortgage-refinancing-calculator-v2/
3. Verify expected years in house field has a years that is present
4. Look at Refinance Analysis tab without any input. Verify top error is the same color on light mode.
5. verify it is dark grey like other messages on dark mode.
6. Verify the info popup works the same since it shares the same color.
7. Ticket: https://stanfordits.atlassian.net/browse/IFDM-186

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials