Repository navigation
🐞 fix: 修复解析QRC时丢失左括号的bug - #926
Conversation
Summary of ChangesHello @apoint123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求修复了一个在解析 QRC 歌词文件时，歌词内容中的左括号会被错误地忽略或丢失的 bug。通过修改用于匹配歌词单词和时间戳的正则表达式，确保了所有字符，包括左括号，都能被正确地解析和保留，从而提高了歌词解析的准确性。 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the bug where the left parenthesis was lost during QRC lyric parsing. The change to the QRC_WORD_PATTERN regex from ([^(]*) to (.*?) correctly captures all characters, including parentheses, before the time-duration group. The reordering of imports is a minor stylistic change.
修复了一个解析 QRC 歌词文件时左括号意外丢失的 bug
例如有歌词行为
[0,21260]Mine(0,1417) (1417,1417)((2834,1417)Illenium(4251,1417) (5668,1417)Remix(7085,1417))(8502,1417)现在可以正确解析出
((2834,1417)的左括号而不会丢失了