Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

🐞 fix: 修复客户端上 **开发人员** 与 **更多贡献者** 头像无法正确显示的问题 - #799

Merged
imsyy merged 4 commits into
SPlayer-Dev:devfrom
ITManCHINA:avatar-fix
Feb 2, 2026
Merged

imsyy merged 4 commits into
SPlayer-Dev:devfrom
ITManCHINA:avatar-fix

Conversation

@ITManCHINA

Copy link
Copy Markdown
Member
修复前 修复后
image image

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ITManCHINA, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决客户端中“关于”页面上开发人员和贡献者头像无法加载或显示不正确的问题。通过在 n-avatar 组件中引入 crossorigin="anonymous" 属性,确保了从不同源加载的图片能够遵守跨域资源共享(CORS)策略,从而允许浏览器正确渲染这些头像。

Highlights

  • 修复头像显示问题: 解决了客户端上“开发人员”和“更多贡献者”头像无法正确显示的问题。
  • 添加跨域属性: 为 n-avatar 组件的 img-props 添加了 crossorigin: 'anonymous' 属性,以确保跨域图片能够正确加载。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了客户端上头像无法正确显示的问题,通过为 n-avatar 组件添加 crossorigin: 'anonymous' 属性来解决跨域图片问题。此更改是正确的。此外,我注意到代码中存在重复,并提出了一个重构建议以提高代码的可维护性。

Comment thread src/components/Setting/AboutSetting.vue Outdated
>
<n-flex align="center">
<n-avatar round :size="40" :src="item.avatar" fallback-src="/images/avatar.jpg?asset" />
<n-avatar round :size="40" :src="item.avatar" fallback-src="/images/avatar.jpg?asset" :img-props="{ crossorigin: 'anonymous' }" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此修复是正确的。不过,我注意到用于显示开发人员信息的卡片组件(62-78行)与后面“更多贡献者”部分(86-108行)的卡片组件几乎完全相同。由于您同时修改了这两处,这会是一个很好的机会来将这部分重复的代码提取到一个单独的组件中(例如 ContributorCard.vue),以提高代码的可维护性。

@imsyy
imsyy merged commit 0de2283 into SPlayer-Dev:dev Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants