Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

🦄 refactor: 重写时间逻辑 - #715

Merged
imsyy merged 3 commits into
devfrom
dev-fix
Jan 5, 2026
Merged

imsyy merged 3 commits into
devfrom
dev-fix

Conversation

@kazukokawagawa

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

本次重构主要集中在 src/utils/time.ts 文件中的时间处理逻辑。通过简化条件判断、优化格式化逻辑以及改进问候语生成方式,提高了代码的简洁性、可读性和可维护性。同时,为所有函数补充了详细的 JSDoc 注释,使得函数功能一目了然。

Highlights

  • 时间格式化函数简化: 重构了 secondsToTime 和 msToTime 函数,通过使用三元运算符替代了冗长的 if/else 结构,使代码更加简洁高效。
  • 日期格式化逻辑优化: 改进了 formatTimestamp 函数,使其在处理同年日期时能够自动省略年份,并优化了 formatCommentTime 函数的逻辑,使其在显示评论时间时能更智能地根据年份进行格式化。
  • 问候语生成方式改进: 重构了 getGreeting 函数,采用数组查找的方式来确定当前时间段的问候语,显著减少了代码量并提高了可读性。
  • JSDoc 注释更新: 为所有时间工具函数添加或更新了详细的 JSDoc 注释,明确了函数的功能、参数和返回值,极大地提升了代码的可维护性和可理解性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 对时间相关的工具函数进行了重构,使代码更加简洁、易读和健壮。使用三元运算符、卫语句和数据驱动的方式替代了冗长的 if-else 链,是非常好的改进。格式化评论时间的逻辑通过直接比较年份变得更加精确。总体而言,这些都是提升代码质量的出色变更。我有一个关于文档的次要建议。

Comment thread src/utils/time.ts
Comment on lines 57 to 60
/**
* 计算进度条移动的距离
* @param {number} currentTime
* @param {number} duration
* @returns {number} 进度条移动的距离,精确到 0.01,最大为 100
* 计算进度条百分比
* @returns 进度百分比,精确到 0.01,范围 0-100
*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

你好,这个函数的 JSDoc 注释更新后更准确地描述了其功能(“计算进度条百分比”),这很棒。不过,新的注释缺少了对 currentTime 和 duration 参数的描述。为了保持文档的完整性和可读性,建议将 @param 标签加回来,以明确函数期望的输入。

/**
 * 计算进度条百分比
 * @param currentTime 当前时间
 * @param duration 总时长
 * @returns 进度百分比,精确到 0.01,范围 0-100
 */

kazukokawagawa and others added 2 commits January 5, 2026 21:25
改掉了变量名 最终输出加了空格 顺便加了点注释
@imsyy
imsyy merged commit 10adb9a into dev Jan 5, 2026
4 checks passed
@imsyy
imsyy deleted the dev-fix branch January 5, 2026 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants